Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor: Remove the custom timeout for Advanced Search playwright #19935

Merged
merged 3 commits into from
Feb 25, 2025
Merged

Minor: Remove the custom timeout for Advanced Search playwright #19935

merged 3 commits into from
Feb 25, 2025

Conversation

aniketkatkar97
Copy link
Member

I worked on removing the custom timeout for the AdvancedSearch.spec.ts to reduce the waiting time

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

@aniketkatkar97 aniketkatkar97 added UI UI specific issues To release Will cherry-pick this PR into the release branch labels Feb 24, 2025
@aniketkatkar97 aniketkatkar97 self-assigned this Feb 24, 2025
@aniketkatkar97 aniketkatkar97 requested a review from a team as a code owner February 24, 2025 09:20
@aniketkatkar97 aniketkatkar97 marked this pull request as draft February 24, 2025 09:20
@github-actions github-actions bot added the safe to test Add this label to run secure Github workflows on PRs label Feb 24, 2025
@github-actions GitHub Actions
Copy link
Contributor

Jest test Coverage

UI tests summary

Lines Statements Branches Functions
Coverage: 64%
 64.74% (41463/64042) 41.11% (16766/40783) 44.37% (5059/11402)

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed for 'open-metadata-ui'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@aniketkatkar97 aniketkatkar97 marked this pull request as ready for review February 24, 2025 14:15
@chirag-madlani chirag-madlani merged commit 08fbd32 into main Feb 25, 2025
15 of 17 checks passed
@chirag-madlani chirag-madlani deleted the reduce-advanced-search-timeout branch February 25, 2025 04:57
@github-actions GitHub Actions
Copy link
Contributor

Failed to cherry-pick changes to the 1.6.5 branch.
Please cherry-pick the changes manually.
You can find more details here.

aniketkatkar97 added a commit that referenced this pull request Feb 25, 2025
@aniketkatkar97
Remove the custom timeout for Advanced Search (#19935)
547cc73
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chirag-madlani chirag-madlani chirag-madlani approved these changes

Assignees

@aniketkatkar97 aniketkatkar97

Labels
safe to test Add this label to run secure Github workflows on PRs To release Will cherry-pick this PR into the release branch UI UI specific issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aniketkatkar97 @chirag-madlani